Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Reset reconnecting state when can_reconnect is false #11926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsaedtler
Copy link
Contributor

Description

Ensures reconnecting is false if reconnection attempts are aborted.

Motivation and Context

Fixes an issue where an output remains "active" after a failed reconnection attempt due to reconnecting never being reset to false.

How Has This Been Tested?

Tested with Twitch and two OBS instances:

  • Instance A streaming with the regular stream key
  • Instance B starting a few seconds later with ?priority=2 appended to the stream key

This will lead to instance B taking over the stream and instance A being disconnected by the streaming platform. Without this change OBS will perpetually be stuck in a semi-active state where the output cannot be restarted as obs_output_active() remains true.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants